[vlc-devel] [PATCH] contrib: do not initialize an empty variable

Rémi Denis-Courmont remi at remlab.net
Wed May 21 19:42:15 CEST 2014


My crappy MUA does not exhibit any visible difference between the two.

As for why this matters, see make documentation.

-- 
Rémi Denis-Courmont
Sent from my NVIDIA Tegra-powered device

----- Reply message -----
De : "Vittorio Giovara" <vittorio.giovara at gmail.com>
Pour : "Mailing list for VLC media player developers" <vlc-devel at videolan.org>
Objet : [vlc-devel] [PATCH] contrib: do not initialize an empty variable
Date : mer., mai 21, 2014 23:10

On Tue, May 20, 2014 at 8:29 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> This is not otherwose equivalent code, so no thank you.

Any hint for the 'correct' solution?

Without the patch you get

Distribution-provided packages:
caca ffi flac fontconfig freetype2 fribidi gettext glib harfbuzz
iconv libxml2 ogg orc png pthreads regex samplerate schroedinger sdl
speexdsp speex sqlite theora vorbis vorbisenc x264 xau zlib
Automatically selected packages:
a52 ass bluray cddb chromaprint dca dvbpsi dvdnav dvdread faad2 ffmpeg
fluid gcrypt gme gnutls goom kate libmpeg2 live555 lua mad matroska
modplug mpcdec opus postproc SDL_image shout sidplay2 ssh2 taglib
tiger twolame upnp vncserver x265 zvbi

with the patch you get

Distribution-provided packages:
caca ffi flac fontconfig freetype2 fribidi gettext glib harfbuzz iconv
libxml2 ogg orc png pthreads regex samplerate schroedinger sdl speexdsp
speex sqlite theora vorbis vorbisenc x264 xau zlib
Automatically selected packages:
a52 ass bluray cddb chromaprint dca dvbpsi dvdnav dvdread faad2 ffmpeg
fluid gcrypt gme gnutls goom kate libmpeg2 live555 lua mad matroska
modplug mpcdec opus postproc SDL_image shout sidplay2 ssh2 taglib
tiger twolame upnp vncserver x265 zvbi

Thanks,
Vittorio
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140522/69cebec4/attachment.html>


More information about the vlc-devel mailing list