[vlc-devel] [PATCH 0/2] Proposition for vlc_gc_xxxref removal

Julien 'Lta' BALLET elthariel at gmail.com
Sat May 24 16:31:46 CEST 2014


From: Julien 'Lta' BALLET <contact at lta.io>

Hi,

I've seen in vlc_input_item.h that the vlc_gc_incref and decref, were
'Historical hacks'. So i've taken the liberty to sed those stuff in the project
to use input_item_Hold/Release.

I wasn't sure if they were kept on purpose or if just nobody removed them yet.

Cheers,
Lta.

--------


Julien 'Lta' BALLET (2):
  Removes the vlc_gc_incref and vlc_gc_decref 'historical hack'
  Replaces vlc_gc_incref and decref by input_item_Hold and Release

 include/vlc_fingerprinter.h                        |  4 ++--
 include/vlc_input_item.h                           |  4 ----
 lib/media.c                                        |  6 ++---
 lib/media_list.c                                   |  2 +-
 modules/access/cdda.c                              |  2 +-
 modules/access/mms/mmsh.c                          |  2 +-
 modules/control/rc.c                               |  2 +-
 modules/demux/mp4/mp4.c                            |  2 +-
 modules/demux/playlist/asx.c                       |  4 ++--
 modules/demux/playlist/b4s.c                       |  4 ++--
 modules/demux/playlist/dvb.c                       |  6 ++---
 modules/demux/playlist/gvp.c                       |  4 ++--
 modules/demux/playlist/ifo.c                       |  8 +++----
 modules/demux/playlist/itml.c                      |  4 ++--
 modules/demux/playlist/m3u.c                       |  4 ++--
 modules/demux/playlist/playlist.c                  |  2 +-
 modules/demux/playlist/pls.c                       |  6 ++---
 modules/demux/playlist/podcast.c                   |  6 ++---
 modules/demux/playlist/qtl.c                       |  6 ++---
 modules/demux/playlist/ram.c                       |  4 ++--
 modules/demux/playlist/sgimb.c                     |  4 ++--
 modules/demux/playlist/shoutcast.c                 |  6 ++---
 modules/demux/playlist/wpl.c                       |  4 ++--
 modules/demux/playlist/xspf.c                      | 26 +++++++++++-----------
 modules/demux/playlist/zpl.c                       |  4 ++--
 modules/gui/macosx/ConvertAndSave.m                |  2 +-
 modules/gui/macosx/playlist.m                      |  6 ++---
 modules/gui/macosx/playlistinfo.m                  | 12 +++++-----
 modules/gui/macosx/wizard.m                        |  2 +-
 modules/gui/qt4/components/interface_widgets.cpp   |  8 +++----
 .../gui/qt4/components/playlist/playlist_item.cpp  |  4 ++--
 .../gui/qt4/components/playlist/playlist_model.cpp |  4 ++--
 modules/gui/qt4/components/playlist/selector.cpp   |  6 ++---
 modules/gui/qt4/dialogs/epg.cpp                    |  4 ++--
 modules/gui/qt4/input_manager.hpp                  |  4 ++--
 modules/gui/skins2/commands/cmd_vars.hpp           |  4 ++--
 modules/lua/extension.c                            |  6 ++---
 modules/lua/libs/input.c                           |  4 ++--
 modules/lua/libs/sd.c                              |  4 ++--
 modules/lua/vlc.c                                  |  2 +-
 modules/services_discovery/bonjour.c               |  2 +-
 modules/services_discovery/mediadirs.c             |  4 ++--
 modules/services_discovery/mtp.c                   |  2 +-
 modules/services_discovery/podcast.c               |  6 ++---
 modules/services_discovery/pulse.c                 |  8 +++----
 modules/services_discovery/sap.c                   |  2 +-
 modules/services_discovery/udev.c                  |  4 ++--
 modules/services_discovery/upnp.cpp                | 16 ++++++-------
 modules/services_discovery/xcb_apps.c              |  4 ++--
 src/input/input.c                                  |  4 ++--
 src/input/item.c                                   |  4 ++--
 src/input/vlm.c                                    |  6 ++---
 src/playlist/engine.c                              |  4 ++--
 src/playlist/fetcher.c                             |  6 ++---
 src/playlist/item.c                                |  6 ++---
 src/playlist/loadsave.c                            |  4 ++--
 src/playlist/preparser.c                           |  6 ++---
 src/playlist/tree.c                                |  2 +-
 test/native/gc.c                                   |  8 +++----
 59 files changed, 146 insertions(+), 150 deletions(-)

--
1.9.3




More information about the vlc-devel mailing list