[vlc-devel] [PATCH 02/10] Adds accessors functions for input_item_t flags

Rémi Denis-Courmont remi at remlab.net
Mon May 26 13:15:05 CEST 2014


Le 2014-05-26 18:56, Julien 'Lta' BALLET a écrit :
> On Mon, May 26, 2014 at 12:11 PM, Rémi Denis-Courmont
> <remi at remlab.net [1]> wrote:
>
>> That patch does not make much sense as a whole. Once the item is
>> unlocked, the flags can change asynchronously, so they cannot be
>> relied upon any longer.
>
> Yep,
>
> Theres imHo an overrusage of mutexes in vlc. Ive just kept the
> behavior i found in the rest of the file.
> On the other hand, can i keep a hold on item mutex during whole
> browsing ?

Items are reference-counted, but other than that I don't know. I don't 
what changes are allowed and not allowed on an existing item, besides 
updating the meta data.

-- 
Rémi Denis-Courmont



More information about the vlc-devel mailing list