[vlc-devel] [vlc-commits] tools: build protoc support libraries as static

[Sean McGovern]

Hi David,

This is only half of the solution I am working on, but still worth having in and of itself. It prevents having to muck around with dynamic linker paths when gcc can't embed a runpath in the protoc binary. The pkgconfig recipe here already does that as well.

As you mentioned, the other half of this fix needs to either:

a) remove the protobuf*.pc files from extras/tools/build/lib/pkgconfig/, or
b) tell the pkgconfig that may or may not be built in extras/tools/ to not use extras/tools/build/lib/pkgconfig as it's pkgconfigdir.

But as I mentioned before, using sed to accomplish (a) runs me into trouble on systems where the vendor supplied sed is not capable of inline editing -- one of which is Solaris.

-- Sean McG.
-----Original Message-----
From: David Fuhrmann <david.fuhrmann at gmail.com>
Sender: "vlc-devel" <vlc-devel-bounces at videolan.org>Date: Sat, 1 Nov 2014 21:36:20 
To: <vlc-devel at videolan.org>
Reply-To: Mailing list for VLC media player developers <vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [vlc-commits] tools: build protoc support libraries
	as static


Am 01.11.2014 um 18:47 schrieb Sean McGovern <git at videolan.org>:

> vlc | branch: master | Sean McGovern <gseanmcg at gmail.com> | Sat Nov  1 10:43:37 2014 -0400| [482beffd24beb289f090841a6e6e8051f7fd59bc] | committer: Jean-Baptiste Kempf
> 
> tools: build protoc support libraries as static
> 
> Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=482beffd24beb289f090841a6e6e8051f7fd59bc
> ---
> 
> extras/tools/tools.mak |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/extras/tools/tools.mak b/extras/tools/tools.mak
> index 33486e6..e249918 100644
> --- a/extras/tools/tools.mak
> +++ b/extras/tools/tools.mak
> @@ -278,7 +278,7 @@ protobuf: protobuf-$(PROTOBUF_VERSION).tar.bz2
>  	$(MOVE)
> 
> .protoc: protobuf
> -	(cd $< && ./configure --prefix="$(PREFIX)" && $(MAKE) && $(MAKE) install)
> +	(cd $< && ./configure --prefix="$(PREFIX)" --disable-shared --enable-static && $(MAKE) && $(MAKE) install)
>  	touch $@

Hello,

I am wondering what is the purpose of this commit? While it prevents to build dynamic libraries for protobuf, the static libraries and the pkg-config files are still there. So, if you run contrib compilation afterwards, it still detects protobuf as already installed (at least for me).

With best regards,
David
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel