[vlc-devel] [PATCH] fix lfind errors on windows

[Martell Malone]

>
> This patch manages to violate the spec, break the build and fix nothing
> (on little endian), all at once.


As defined in mingw-w64-headers/crt/search.h
_CRTIMP void *__cdecl _lfind(const void *_Key,const void *_Base,unsigned
int *_NumOfElements,unsigned int _SizeOfElements,int (__cdecl
*_PtFuncCompare)(const void *,const void *
));

unsigned int *_NumOfElements;

I already discussed this with the mingw-w64 devs and they said the must
comply with what msvcrt does because you can only have one function
definition with one name in C.
Their advice is for vlc to make an exception when using lfind.

Maybe I am missing something but could you explain how this patch breaks
the build ?
And / Or recommend some changes to it in terms of spec.

This is my first patch so forgive me if it doesn't conform


On Mon, Nov 3, 2014 at 12:42 PM, Rémi Denis-Courmont <remi at remlab.net>
wrote:

> Le 2014-11-03 15:30, Martell Malone a écrit :
>
>> MS dont conform to the size_t argument and always use unsigned int
>> even on x64
>> This was applied to 2.2 branch but should also be able to go onto HEAD
>>
>
> This patch manages to violate the spec, break the build and fix nothing
> (on little endian), all at once.
>
> Nack.
>
> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20141103/17497e76/attachment.html>