[vlc-devel] [PATCH] vlccore: export all symbols on OS/2

[KO Myung-Hun]

Hi/2.

Jean-Baptiste Kempf wrote:
> This feels very very wrong.
> 

Any suggestion ?

OS/2 libtool updated to support exporting symbols. Before, it exported
all symbols.


> On 30 Oct, KO Myung-Hun wrote :
>> Ping ?
>>
>> KO Myung-Hun wrote:
>>> OS/2 has additional symbols not listed in libvlccore.sym. They are
>>> vlc_poll() and freeaddrinfo(). So the modules using them cannot be
>>> linked.
>>> ---
>>>  src/Makefile.am |    4 +++-
>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/src/Makefile.am b/src/Makefile.am
>>> index 1e113c9..ed56464 100644
>>> --- a/src/Makefile.am
>>> +++ b/src/Makefile.am
>>> @@ -181,8 +181,10 @@ libvlccore_la_SOURCES = $(SOURCES_libvlc)
>>>  libvlccore_la_LDFLAGS = \
>>>  	$(LDFLAGS_libvlccore) \
>>>  	-no-undefined \
>>> -	-export-symbols $(srcdir)/libvlccore.sym \
>>>  	-version-info 8:0:0
>>> +if !HAVE_OS2
>>> +libvlccore_la_LDFLAGS += -export-symbols $(srcdir)/libvlccore.sym
>>> +endif
>>>  libvlccore_la_LIBADD = $(LIBS_libvlccore) \
>>>  	../compat/libcompat.la \
>>>  	$(LTLIBINTL) $(LTLIBICONV) \
>>
>> -- 
>> KO Myung-Hun
>>
>> Using Mozilla SeaMonkey 2.7.2
>> Under OS/2 Warp 4 for Korean with FixPak #15
>> In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
>>
>> Korean OS/2 User Community : http://www.ecomstation.co.kr
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr