[vlc-devel] [PATCH] fix lfind errors on windows

[Rémi Denis-Courmont]

Le 2014-11-04 15:03, Martell Malone a écrit :
> The issue here is there is nothing wrong with mingw-w64 as they link
> to msvcrt
> As defined here http://msdn.microsoft.com/en-us/library/a6xkkxfz.aspx
> [3]
>
> On little endian we can just ignore the warning but depending in the
> strictness of the build / package system this is not an option.

I can conceive four cases:

1) lfind() is inline,
2) lfind() is statically linked and LTO is active,
3) lfind() is statically linked but LTO is inactive,
4) lfidn() is dynamically linked.

The pointer aliasing violation is only a potential problem in cases 1 
and 2. But binary compatibility with the CRT is only a concern in case 
4. And even then, a small wrapper that converts back-and-forth would not 
be hard.

So I fail to see an excuse. I'm totally not merging that ugly ifdef 
hack.

-- 
Rémi Denis-Courmont