[vlc-devel] [PATCH 2/2] dvdnav: fix compilation on OS/2

[KO Myung-Hun]

Hi/2.

Rémi Denis-Courmont wrote:
> Le mercredi 05 novembre 2014, 12:33:23 KO Myung-Hun a écrit :
>> -----
>> access/dvdnav.c: In function 'ProbeDVD':
>> access/dvdnav.c:1469:6: error: implicit declaration of function 'read'
>> [-Werror=implicit-function-declaration]
>>       || read( fd, iso_dsc, sizeof (iso_dsc) ) < (int)sizeof (iso_dsc)
>>
>>       ^
>> access/dvdnav.c:1481:5: error: implicit declaration of function 'close'
>> [-Werror=implicit-function-declaration] close( fd );
>>      ^
>> -----
>> ---
>>  modules/access/dvdnav.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/modules/access/dvdnav.c b/modules/access/dvdnav.c
>> index 553ef43..2e25bf4 100644
>> --- a/modules/access/dvdnav.c
>> +++ b/modules/access/dvdnav.c
>> @@ -39,6 +39,7 @@
>>
>>  #include <assert.h>
>>  #include <sys/stat.h>
>> +#include <io.h>
> 
> That should be <unistd.h> I think.
> 

Ok. BTW, I have been fixing this issue repeatedly. So I think, it would
be better to include unistd.h or io.h in vlc_common.h on OS/2.

Any ideas ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr