[vlc-devel] [PATCH 1/1] Resolves protoc version compatibility problems.

[Rémi Denis-Courmont]

Le 2014-11-13 08:03, Waterson a écrit :
> Chromecast and Protobuf itself use the stock version of protoc
> on the build-system by default, which may not be compatible.
> To avoid this problem, we build a version of protoc for the
> build-system first, and use it consistently throughout the whole
> build process.
>
> This patch is adapted from MXE, an excellent Mingw cross build 
> environment.
> ---
>  contrib/src/main.mak              |    1 +
>  contrib/src/protobuf/SHA512SUMS   |    2 +-
>  contrib/src/protobuf/rules.mak    |   17 ++++++++++++++---
>  extras/package/win32/configure.sh |    1 +
>  4 files changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
> index 97e2b62..bed737b 100644
> --- a/contrib/src/main.mak
> +++ b/contrib/src/main.mak
> @@ -352,6 +352,7 @@ install: $(PKGS:%=.%)
>  mostlyclean:
>  	-$(RM) $(foreach p,$(PKGS_ALL),.$(p) .sum-$(p) .dep-$(p))
>  	-$(RM) toolchain.cmake
> +	-$(RM) -R "$(PREFIX)/../bin"

No. You cannot clean anything outside of the build directory and the 
installation prefix. That would break building multiple targets.

(And conversely, nothing should be there that is not shared by all 
targets, meaning basically source tarballs and build rules.)

-- 
Rémi Denis-Courmont