[vlc-devel] [PATCH 2/3] dvdnav: fix compilation on OS/2

Vittorio Giovara vittorio.giovara at gmail.com
Thu Nov 13 12:05:20 CET 2014


On Thu, Nov 13, 2014 at 9:07 AM, KO Myung-Hun <komh78 at gmail.com> wrote:
> -----
> access/dvdnav.c: In function 'ProbeDVD':
> access/dvdnav.c:1469:6: error: implicit declaration of function 'read' [-Werror=implicit-function-declaration]
>       || read( fd, iso_dsc, sizeof (iso_dsc) ) < (int)sizeof (iso_dsc)
>       ^
> access/dvdnav.c:1481:5: error: implicit declaration of function 'close' [-Werror=implicit-function-declaration]
>      close( fd );
>      ^
> -----
> ---
>  modules/access/dvdnav.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/modules/access/dvdnav.c b/modules/access/dvdnav.c
> index 553ef43..ad1240a 100644
> --- a/modules/access/dvdnav.c
> +++ b/modules/access/dvdnav.c
> @@ -41,6 +41,7 @@
>  #include <sys/stat.h>
>  #include <fcntl.h>
>  #include <errno.h>
> +#include <unistd.h>     /* close() */

comments about which functions are included get outdated quickly, so
I'd avoid doing that

-- 
Vittorio



More information about the vlc-devel mailing list