[vlc-devel] [PATCH] sap: search x-plgroup also in media-level attrs

[Santiago Gimeno]

I know, but I've old hardware that sets the x-plgroup in the media-level
attributes (apparently this hardware uses miniSAPServer 0.3.2) and this
case was handled in older versions of vlc.

2014-11-17 15:08 GMT+01:00 Rémi Denis-Courmont <remi at remlab.net>:

> Le 2014-11-17 17:00, Santiago Gimeno a écrit :
>
>> diff --git a/modules/services_discovery/sap.c
>> b/modules/services_discovery/sap.c
>> index 5477924..d27f991 100644
>> --- a/modules/services_discovery/sap.c
>> +++ b/modules/services_discovery/sap.c
>> @@ -908,8 +908,13 @@ sap_announce_t *CreateAnnounce(
>> services_discovery_t *p_sd, uint32_t *i_source,
>>      else
>>      {
>>          /* backward compatibility with VLC 0.7.3-2.0.0 senders */
>> -        psz_value = GetAttribute(p_sap->p_sdp->pp_attributes,
>> -                                 p_sap->p_sdp->i_attributes,
>> "x-plgroup");
>> +        if (p_sap->p_sdp->mediac >= 1) {
>> +            psz_value = FindAttribute(p_sap->p_sdp, 0, "x-plgroup");
>>
>
> This is not making any sense. How can you put a single media in a playlist
> and not the whole session?!
>
>
> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20141117/8f29fc39/attachment.html>