[vlc-devel] [PATCH] Fix the latest mingw-w64 crt trunk

[Martell Malone]

Hi Remi,

Sorry for the confusion.

Previously mingw-w64 had defines like this

#define localtime_r( ......
#define gmtime_r( ......

so autotools did not pick these up as functions as they were #defines

I got a patch merged where these are now actual functions in the mingw-w64
crt
autotools now detects gmtime_r and localtime_r so HAVE_GMTIME_R and
HAVE_LOCALTIME_R get defined.

On mingw-w64 we still need time.h to be included in vlc_fixups.h otherwise
we will get undefined references to the time function itself.

by "emulation functions" I mean that gmtime_r and localtime_r are
implemented using the windows api.
The mingw-w64 team calls these emulated functions.
They are also thread safe just incase you were wondering :)

Kindest Regards
Martell


On Tue, Nov 18, 2014 at 3:11 PM, Rémi Denis-Courmont <remi at remlab.net>
wrote:

> Le 2014-11-18 17:50, Martell Malone a écrit :
>
>> I have added emulation functions for gmtime_r and localtime_r to
>> mingw-w64.
>> As a result on latest mingw-w64 trunk HAVE_GMTIME_R
>> and HAVE_LOCALTIME_R are defined so we need to add an extra option
>> for mingw-w64 to include time.h in fixups.
>>
>
> I am not sure what you exactly mean by "emulation functions" and I don't
> follow the rest.
>
> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20141118/30464270/attachment.html>