[vlc-devel] [PATCH] Fix the latest mingw-w64 crt trunk

Martell Malone martellmalone at gmail.com
Tue Nov 18 20:06:33 CET 2014


I will do them all one by one then.
I will include time.h in thread.c and any other file that uses the time
function.

This does mean that this bug was present in vlc already.
It's just HAVE_GMTIME_R and HAVE_LOCALTIME_R were never true for vlc under
mingw-w64 before.
So the developers never included time.h where they used it

You can do whatever is most convenient for you or your organization within
> your VLC fork or VLC patch series. But upstream, you get to fix bugs
> properly, even if it means one by one.


This is not for another fork of vlc this is so that you guys can build for
WinRT under latest trunk


On Tue, Nov 18, 2014 at 6:41 PM, Rémi Denis-Courmont <remi at remlab.net>
wrote:

> Le 2014-11-18 19:17, Martell Malone a écrit :
>
>> If I include time.h in thread.c the error appears somewhere else then
>> if I patch that it appears somewhere else again and so on.
>> This is why I changed vlc_fixups.h to fix them all.
>>
>> Im not sure if there is another solution but
>> I can go through them all 1 by 1 if you want ?
>> It will be time consuming is all.
>>
>> Either way I need to get this fixed. :)
>>
>
> You can do whatever is most convenient for you or your organization within
> your VLC fork or VLC patch series. But upstream, you get to fix bugs
> properly, even if it means one by one.
>
>
> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20141118/8204d278/attachment.html>


More information about the vlc-devel mailing list