[vlc-devel] [RFC PATCH 5/6] decoder: add decoder_QueuePicture

Rémi Denis-Courmont remi at remlab.net
Wed Nov 19 10:04:20 CET 2014


Le 2014-11-19 11:39, Thomas Guillem a écrit :
> On Wed, Nov 19, 2014, at 09:31, Julian Scheel wrote:
>> Am 03.11.2014 um 19:51 schrieb Rémi Denis-Courmont:
>> > Le lundi 03 novembre 2014, 19:41:21 Thomas Guillem a écrit :
>> >> This function allow asynchronous decoders to queue a picture to 
>> the render
>> >> thread. Theses decoders should return NULL in pf_decode callback.
>> >
>> > Seems OK, though it should probably implemented in other decoder_t 
>> owners in
>> > the long term.
>>
>> Anything which stops us from merging this?
>> I'd like to port the mmal decoder to use it as well.
>
> I have a new version that check for DecoderIsExitRequested before
> queuing the picture.

I think that check would not make any sense. It would be fundamentally 
racy and any decoder that would rely on this would thus be prone to dead 
lock.

-- 
Rémi Denis-Courmont



More information about the vlc-devel mailing list