[vlc-devel] [vlc-commits] libmp4: Use a portable format specified for uintmax_t

Hugo Beauzée-Luyssen hugo at beauzee.fr
Fri Nov 28 11:03:15 CET 2014


Hi,

On Fri, Nov 28, 2014, at 10:55 AM, Rémi Denis-Courmont wrote:
> Le 2014-11-28 12:48, David Fuhrmann a écrit :
> > Am 28.11.2014 um 10:33 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> >
> >> This implies that 0d881ef1d5c711e96236c97aa1e8d196fda7e9d7 is not 
> >> portable and wrong, which is FALSE
> >
> > Out of curiosity: Why?
> 
> Obviously C99 7.9.16.1 §7.

My draft doesn't have a 7.9.16, though it might be outdated.

> 
> > Any docu I find tells that PRIuMAX is exactly meant for uintmax_t.
> 
> And... ?

It makes the code non portable, specifically, visual studio ignores %ju,
while it understands PRIuMAX properly.
I fail to understand what's wrong with this commit, beside and eventual
wording problem in the commit log.

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr



More information about the vlc-devel mailing list