[vlc-devel] [vlc-commits] access/file: don't read-ahead when processing remote contents ( closes #9885, refs #8446)

Rémi Denis-Courmont remi at remlab.net
Fri Nov 28 13:21:36 CET 2014

Le 2014-11-28 14:01, Jean-Baptiste Kempf a écrit :
> On 25 Nov, Tobias Güntner wrote :
>> I think this applies to vdr as well so I moved the code in a helper
>> function. Works for me but it still needs to be tested on OS X.
> This email is confusing in the way you sent it, to be honest.
>> Subject: [PATCH 1/3] Move remote file check to core
> Needs Rémi OK, but LGTM.

I don't really see the point. In any case, there should be no path 
argument w.r.t. ToCToU.

>> Subject: [PATCH 2/3] Create helper function to set readahead and 
>> caching
>> +VLC_API void vlc_optimize_read( int fd, const char *path );
> This name is not cool.
> Rémi?

I think it's pointless. Read-ahead should not be enabled blindly, and 
this is only done on MacOS.

Rémi Denis-Courmont

More information about the vlc-devel mailing list