[vlc-devel] [PATCH] lib/media_player: inherit deinterlace and vbi variables to fix correct variables values on first use

[Rémi Denis-Courmont]

Le 2014-11-29 14:47, Felix Paul Kühne a écrit :
> ---
>  lib/media_player.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/media_player.c b/lib/media_player.c
> index 9a7961f..0697e42 100644
> --- a/lib/media_player.c
> +++ b/lib/media_player.c
> @@ -526,10 +526,10 @@ libvlc_media_player_new( libvlc_instance_t 
> *instance )
>      var_Create (mp, "zoom", VLC_VAR_FLOAT | VLC_VAR_DOINHERIT);
>      var_Create (mp, "aspect-ratio", VLC_VAR_STRING);
>      var_Create (mp, "crop", VLC_VAR_STRING);
> -    var_Create (mp, "deinterlace", VLC_VAR_INTEGER);
> +    var_Create (mp, "deinterlace", VLC_VAR_INTEGER | 
> VLC_VAR_DOINHERIT);

That's pointless. The initial value is zero either way.

>      var_Create (mp, "deinterlace-mode", VLC_VAR_STRING);
>
> -    var_Create (mp, "vbi-page", VLC_VAR_INTEGER);
> +    var_Create (mp, "vbi-page", VLC_VAR_INTEGER | 
> VLC_VAR_DOINHERIT);

Probably ok.

>      var_Create (mp, "marq-marquee", VLC_VAR_STRING);
>      var_Create (mp, "marq-color", VLC_VAR_INTEGER | 
> VLC_VAR_DOINHERIT);

-- 
Rémi Denis-Courmont