[vlc-devel] [PATCH] libvlc: add preliminary code path to modify quartztext variables on-the-fly

[Jean-Baptiste Kempf]

On 29 Nov, Felix Paul Kühne wrote :
>  include/vlc/libvlc_media_player.h  | 21 +++++++++++++
>  lib/libvlc.sym                     |  4 +++
>  lib/media_player.c                 |  6 ++++
>  lib/video.c                        | 47 +++++++++++++++++++++++++++++
>  modules/text_renderer/quartztext.c | 60 +++++++++++++++++++++++++++++++++-----
>  5 files changed, 130 insertions(+), 8 deletions(-)
> 
> diff --git a/include/vlc/libvlc_media_player.h b/include/vlc/libvlc_media_player.h
> index 1c73cf2..68d0b3b 100644
> --- a/include/vlc/libvlc_media_player.h
> +++ b/include/vlc/libvlc_media_player.h
> @@ -1383,6 +1383,27 @@ LIBVLC_API float libvlc_video_get_adjust_float( libvlc_media_player_t *p_mi,
>  LIBVLC_API void libvlc_video_set_adjust_float( libvlc_media_player_t *p_mi,
>                                                     unsigned option, float value );
>  
> +/** option values for libvlc_video_{get,set}_adjust_{int,float,bool} */
> +enum libvlc_video_textrenderer_option_t {
> +    libvlc_textrender_font = 0,
> +    libvlc_textrender_fontsize,
> +    libvlc_textrender_fontcolor,
> +};

I would argue you should set the whole style, not one parameter per one
parameter.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device