[vlc-devel] [vlc-commits] udp: don't realloc in receiving, just set i_buffer
ileoo at videolan.org
Wed Oct 1 06:40:19 CEST 2014
On Tue, Sep 30, 2014 at 10:07:21PM +0300, Rémi Denis-Courmont wrote:
> Le mardi 30 septembre 2014, 20:40:44 Ilkka Ollakka a écrit :
> > Similar than rtp input does, doing realloc from 64k->1.5k would
> > usually mean extra malloc+memcpy per packet.
> > Also don't pass buffer onward if we don't receive any useful stuff (-1)
> Hmm? I think the 'continue' statement was already taking care of that.
> Otherwise we would have had a use-after-free. Now the 'continue' is redundant.
Yes you are right, for some reason I overlooked that. I'll remove that
else block so it's more closer to original flow.
I used to be an agnostic, but now I'm not so sure.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the vlc-devel