[vlc-devel] [vlc-commits] configure: enable init-self and logical-op warnings

[David Fuhrmann]

Am 17.09.2014 um 23:12 schrieb Rémi Denis-Courmont <git at videolan.org>:

> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Sep 18 00:12:30 2014 +0300| [a8f7d9fa64a4d0481a193192c048ba4a99c19888] | committer: Rémi Denis-Courmont
> 
> configure: enable init-self and logical-op warnings
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a8f7d9fa64a4d0481a193192c048ba4a99c19888
> ---
> 
> configure.ac |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index d3d5517..2b2a815 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -860,7 +860,7 @@ dnl
> dnl  Compiler warnings
> dnl
> 
> -RDC_PROG_CC_WFLAGS([all extra sign-compare undef pointer-arith bad-function-cast write-strings missing-prototypes volatile-register-var error-implicit-function-declaration])
> +RDC_PROG_CC_WFLAGS([all extra sign-compare undef pointer-arith bad-function-cast write-strings missing-prototypes volatile-register-var error-implicit-function-declaration init-self logical-op])
> RDC_PROG_CC_FLAGS([-pipe])
> AC_LANG_PUSH([C++])
> RDC_PROG_CXX_WFLAGS([all extra sign-compare undef pointer-arith volatile-register-var])

Hi,

Unfortunately, not all compilers (notably recent clang on osx) have the logical-op warning. Now the build log is spawned at every occasion with:

warning: unknown warning option '-Wlogical-op'; did you mean '-Wlong-long'? [-Wunknown-warning-option]

While this is fine for me, for now, it would be nice to get rid of it on the longer run.

With best regards,
David