[vlc-devel] [PATCH 1/1] block: use PAGE_SIZE to determine when to do malloc+memcpy
remi at remlab.net
Sat Oct 4 14:41:33 CEST 2014
Le samedi 4 octobre 2014, 12:52:48 Ilkka Ollakka a écrit :
> On Sat, Oct 04, 2014 at 12:07:01PM +0300, Rémi Denis-Courmont wrote:
> > Le samedi 4 octobre 2014, 11:44:57 Ilkka Ollakka a écrit :
> > > + /* Maximum size of reserved footer before shrinking with realloc().
> > > + * FIXME: this is basicly limit where is
> > > + * meaningfull to do malloc/memcpy vs wasted memory size, so
> > > + * is PAGE_SIZE good limit or should it be n*PAGE_SIZE where n > 1?
> > "This is basically the threshold from which malloc()/memcpy() actually
> > saves memory." ?
> Ah yes, I'll change that wording. Should here be consireded also that is
> it worth spending time for malloc and memcpy to just save 1 page?
I don't really care so long as it is in proper English.
More information about the vlc-devel