[vlc-devel] [PATCH v2 8/9] android: hack sys/shm.h detection for android-L

[Jean-Baptiste Kempf]

On 09 Oct, Rémi Denis-Courmont wrote :
> Le jeudi 9 octobre 2014, 18:45:26 Thomas Guillem a écrit :
> > ---
> >  include/vlc_fixups.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/include/vlc_fixups.h b/include/vlc_fixups.h
> > index e515763..71afd94 100644
> > --- a/include/vlc_fixups.h
> > +++ b/include/vlc_fixups.h
> > @@ -357,4 +357,11 @@ long nrand48 (unsigned short subi[3]);
> >  #define nanf(tagp) NAN
> >  #endif
> > 
> > +#ifdef __ANDROID__
> > +/* TODO: Check if these hacks are still needed when android-L is released.
> > + * android-L has empty sys/shm.h headers that triggers shm detection but it
> > + * doesn't have any shm functions and/or symbols. */
> 
> Was this reported? If so, do we wait or do we merge it anyway?

Well, the issue is we have NO idea what they want to do:
 - Until Android-L, there is no sys/shm.h at all.
 - In Android-L, there is an almost empty sys/shm.h, that redirects to
   linux/shm.h.
   This linux/shm.h defines a few CONSTANTS, but no shmat|shmdt symbols
   are present in the libc.so.

We use the sys/shm.h detection and not the symbols. So I have no idea
what is the right path of action.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device