[vlc-devel] [PATCH v2] mmal/vout: Support native interlaced modes

[Julian Scheel]

Am 11/10/14 um 12:44 schrieb Jean-Baptiste Kempf:
> On 10 Oct, Julian Scheel wrote :
>> +#define MMAL_NATIVE_INTERLACE_TEXT N_("Try to render interlaced video in native mode.")
>
> Too convoluted, unclear and not-generic enough sentence.
>
>> +#define MMAL_NATIVE_INTERLACE_LONGTEXT N_("Tries to setup an interlaced video mode which matches the video format. This allows the connected display to handle the deinterlacing.")
>
> Idem.

I'll try to make up something better...

>>       bool adjust_refresh_rate;
>> +    bool native_interlaced;
>> +    bool b_top_field_first;
>>       int next_phase_check;
>> +    bool b_progressive;
>>       int phase_offset;
>
> Your packing is not really good, to be honest.

Ack, I'll repack. I fell back into using inverse christmas tree for 
beauty of code here ;)

>>       int layer;
>> @@ -311,6 +320,7 @@ static void Close(vlc_object_t *object)
>>   {
>>       vout_display_t *vd = (vout_display_t *)object;
>>       vout_display_sys_t *sys = vd->sys;
>> +    char response[80];
>
> Why 80?

tbh because the reference implementation did the same. In fact there's 
no reliable documentation on what would be needed. I'll try to sort it 
out...