[vlc-devel] [PATCH] configure: add tools from extras/tools to the PATH

[gseanmcg at gmail.com]

Hi Rémi & Jean-Baptiste,

Please don't consider my comment a rejection of this patch. I misunderstood the intention.

It appears those lines in contrib/src/main.mak don't work on the OS X buildslaves as they are still unable to find protoc when building protobuf.

-- Sean McG.
Sent on the TELUS Mobility network with BlackBerry

-----Original Message-----
From: Rémi Denis-Courmont <remi at remlab.net>
Sender: "vlc-devel" <vlc-devel-bounces at videolan.org>Date: Sat, 11 Oct 2014 18:16:55 
To: <vlc-devel at videolan.org>
Reply-To: Mailing list for VLC media player developers <vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH] configure: add tools from extras/tools to
	the PATH

Le samedi 11 octobre 2014, 14:54:47 gseanmcg at gmail.com a écrit :
> Hi Jean-Baptiste,
> 
> This won't help for contrib/, where it is most needed for building protobuf.

It does not help but it does not hurt either, does it? Also why do you want 
protobuf while building contribs? I cannot see any packages depending on it.

Regardless, contribs already pulls in tools in src/main.mak:

| PATH :=$(abspath ../../extras/tools/build/bin):$(PATH)
| export PATH

-- 
Rémi Denis-Courmont
http://www.remlab.net/

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel