[vlc-devel] [PATCH 1/1] dvdnav: add external access module support

[Rémi Denis-Courmont]

Le vendredi 17 octobre 2014, 17:47:46 Thomas Guillem a écrit :
> Use the following url: "dvd://http://" to open a DVD iso via http.

No. That´s not what that URL means. It means file <empty string> on host <http> 
with port <empty string>.


> @@ -175,6 +176,26 @@ static int EventIntf( vlc_object_t *, char const *,
>                        vlc_value_t, vlc_value_t, void * );
> 
>  /**************************************************************************
> *** + * dvdnav stream callbacks
> +
> ***************************************************************************
> **/ +static int stream_cb_seek( void *s, uint64_t pos )
> +{
> +    return stream_Seek( (stream_t *)s, pos );
> +}
> +
> +static int stream_cb_read( void *s, void* buffer, int size )
> +{
> +    return stream_Read( (stream_t *)s, buffer, size );
> +}

It´s far from that easy. dvdnav and dvdread normally use regular files or block 
devices. They cannot "block", they either return success or a fatal error 
immediately (from a scheduling point of view).

VLC´s stream_t definitely can block, especially when wrapping a network 
resources. This would cause freezes or even lockups in certain circumstances.

-- 
Rémi Denis-Courmont
http://www.remlab.net/