[vlc-devel] [PATCH 2/2] vlccore: export vlc_poll() and freeaddrinfo()

Rémi Denis-Courmont remi at remlab.net
Mon Oct 20 11:53:55 CEST 2014


Le 2014-10-16 10:53, KO Myung-Hun a écrit :
> Rémi Denis-Courmont wrote:
>> Le 2014-10-14 03:37, KO Myung-Hun a écrit :
>>> Some symbols are defined only in OS/2. So as Rémi said, it breaks 
>>> other
>>> builds, especially Windows, when adding those symbols to 
>>> libvlccore.sym
>>> unconditionally.
>>
>> As a general rule, replacement functions are added to the compat
>> library, which has no restrictions on exported symbols.
>
> Yes. But it is not for this case, at least vlc_poll().

That is why vlc_poll() is an inline function.

If you want to put it out-of-line, then you need to write a poll() 
function in compat instead. That's more work.

-- 
Rémi Denis-Courmont



More information about the vlc-devel mailing list