[vlc-devel] [PATCH] mediacodec: no software rendering before api 18

Martin Storsjö martin at martin.st
Wed Oct 22 19:37:07 CEST 2014


On Wed, 22 Oct 2014, Thomas Guillem wrote:

> Avoid crashes by rendering unknown YUV buffers since "color-format" can't be
> trusted before api 18.
> ---
> modules/codec/omxil/android_mediacodec.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)

Why should we disallow this completely? It works just fine on a number of 
devices. Sure, not reliable across untested devices, but that's why we 
have the device whitelist so we don't enable it automatically on random 
devices, so it's only a problem if you intentionally enable the option.

// Martin



More information about the vlc-devel mailing list