[vlc-devel] [PATCH 12/12] configure.ac: Do not generate invalid pragmas on MSVC

Hugo Beauzee-Luyssen hugo at beauzee.fr
Thu Oct 23 14:14:00 CEST 2014


On 10/23/2014 01:39 PM, Rémi Denis-Courmont wrote:
> Le 2014-10-23 13:17, Hugo Beauzée-Luyssen a écrit :
>> ---
>>  configure.ac | 9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 44e5bdf..9c3c52c 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -999,8 +999,13 @@ AS_IF([test "${enable_optimizations}" != "no"], [
>>    AS_IF([test "${ac_cv_c_fast_math}" = "no"], [VLC_RESTORE_FLAGS])
>>    AH_BOTTOM([
>>  #ifndef __FAST_MATH__
>> -# pragma STDC FENV_ACCESS OFF
>> -# pragma STDC FP_CONTRACT ON
>> +# ifndef _MSC_VER
>> +#  pragma STDC FENV_ACCESS OFF
>> +#  pragma STDC FP_CONTRACT ON
> 
> Invalid pragma? This is *_STANDARD_* ISO C.

Bad wording on my side. What I meant is "invalid as far as MSVC is
concerned"
I agree this is valid C, and should be understood. I'll open a ticket on
visual studio "bugtracker".

> 
>> +# else
>> +#  pragma fenv_access(off)
>> +#  pragma fp_contract(on)
>> +# endif
>>  #endif
>>  ])
> 

Regards,

-- 
Hugo Beauzée-Luyssen
hugo at beauzee.fr
+33-7-83-33-84-08

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20141023/66a1a8a2/attachment.sig>


More information about the vlc-devel mailing list