[vlc-devel] [PATCH 10/12] contribs: ffmpeg/libav: Properly pass NM/AR env variables

[Hugo Beauzee-Luyssen]

On 10/24/2014 04:33 PM, Rémi Denis-Courmont wrote:
> Le 2014-10-23 15:11, Hugo Beauzee-Luyssen a écrit :
>> On 10/23/2014 01:38 PM, Rémi Denis-Courmont wrote:
>>> Le 2014-10-23 13:17, Hugo Beauzée-Luyssen a écrit :
>>>> ---
>>>>  contrib/src/ffmpeg/rules.mak | 8 ++++++++
>>>>  1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/contrib/src/ffmpeg/rules.mak
>>>> b/contrib/src/ffmpeg/rules.mak
>>>> index 9712478..18ffe02 100644
>>>> --- a/contrib/src/ffmpeg/rules.mak
>>>> +++ b/contrib/src/ffmpeg/rules.mak
>>>> @@ -163,6 +163,14 @@ ifeq ($(call need_pkg,"libavcodec >= 54.25.0
>>>> libavformat >= 53.21.0 libswscale")
>>>>  PKGS_FOUND += ffmpeg
>>>>  endif
>>>>
>>>> +ifdef NM
>>>> +FFMPEGCONF += --nm="$(NM)"
>>>> +endif
>>>> +
>>>> +ifdef AR
>>>> +FFMPEGCONF += --ar="$(AR)"
>>>> +endif
>>>
>>> How can AR or NM be undefined?
>>
>> I must say I don't see why it would have to be
> 
> I don't understand what you mean there, but AR and NM are both always
> defined AFAICT.
> 

Oh ok after reading Make's documentation I understand what you mean, and
indeed you're correct, I'll remove the check.

Regards,

-- 
Hugo Beauzée-Luyssen
hugo at beauzee.fr
+33-7-83-33-84-08

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20141024/9b029b3b/attachment.sig>