[vlc-devel] [PATCH 2/2] vlccore: export vlc_poll() and freeaddrinfo()

[KO Myung-Hun]

KO Myung-Hun wrote:
> 
> 
> Rémi Denis-Courmont wrote:
>> Le 2014-10-16 10:53, KO Myung-Hun a écrit :
>>> Rémi Denis-Courmont wrote:
>>>> Le 2014-10-14 03:37, KO Myung-Hun a écrit :
>>>>> Some symbols are defined only in OS/2. So as Rémi said, it breaks other
>>>>> builds, especially Windows, when adding those symbols to libvlccore.sym
>>>>> unconditionally.
>>>>
>>>> As a general rule, replacement functions are added to the compat
>>>> library, which has no restrictions on exported symbols.
>>>
>>> Yes. But it is not for this case, at least vlc_poll().
>>
>> That is why vlc_poll() is an inline function.
>>
>> If you want to put it out-of-line, then you need to write a poll()
>> function in compat instead. That's more work.
>>
> 
> poll() is already in compat(). In addition, OS/2 vlc_poll() is
> implemented separately in src/os2/thread.c, using its internal vlc
> function. So I don't think it's possible to put vlc_poll() into compat.
> 
> 

Rejected ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr