[vlc-devel] [PATCH] decoder: unblock broken decoders when flushing

Thomas Guillem tom at gllm.fr
Tue Oct 28 09:43:02 CET 2014

Ah yes, you are right, I can't discard the output like that. I didn't
see that it was a dangerous change.

I made an other patch, still in the core, that won't discard the output
(see next mail answered in this thread)

I'm sorry to insist but this deadlock is a stopper for the 1.0 android
release. It is really easy to reproduce, and I need to find a way to
avoid it. Of course I would prefer to don't hack the core for that but I
didn't find any other way. If you have some hints, I would be happy to
hear them.

On Mon, Oct 27, 2014, at 17:11, Rémi Denis-Courmont wrote:
> Le lundi 27 octobre 2014, 14:25:24 Thomas Guillem a écrit :
> > Sorry, I was not clear enough: the deadlock happens when you seek a
> > paused video. So there is a flush in that case, even if the video is
> > paused, right ?
> When seeking, the decoder input queue is flushed, and then refilled with
> new 
> content. So you can´t just blindly discard the output - this is not even 
> specific to the paused state.
> That race-prone ugly hack works for exiting - only.
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list