[vlc-devel] [PATCH] libmp4: fix segfault

Frédéric Yhuel yhuelf at gmail.com
Thu Oct 30 14:25:46 CET 2014


On Wed, Oct 29, 2014 at 7:22 PM, Frédéric Yhuel <yhuelf at gmail.com> wrote:
> On Wed, Oct 29, 2014 at 5:38 PM, Francois Cartegnie <fcvlcdev at free.fr> wrote:
>> Le 28/10/2014 23:11, Frédéric Yhuel a écrit :
>>>  static int MP4_NextBox( stream_t *p_stream, MP4_Box_t *p_box )
>>>  {
>>> -    MP4_Box_t box;
>>> +    MP4_Box_t box = {0};
>>>
>>>      if( !p_box )
>>>      {
>>>
>>
>> Better fail early. (untested, no sample)
>>
>
> It seems better indeed. You can test it with the following stream
> (play it to the end):
> http://mediadl.microsoft.com/mediadl/iisnet/smoothmedia/Experience/BigBuckBunny_72.ism/Manifest
>

François, I let you commit, right?

Or do you want me to send another patch?

Best regards,
Frédéric



More information about the vlc-devel mailing list