[vlc-devel] [PATCH 3/3] subtitle-demux: fix memory leaks (fixes #11908)

Tristan Matthews le.businessman at gmail.com
Wed Sep 10 17:42:56 CEST 2014


On Wed, Sep 10, 2014 at 7:11 AM, Hannes Domani <ssbssa at yahoo.de> wrote:
> Rémi Denis-Courmont <remi at remlab.net> schrieb am 8:56 Mittwoch, 10.September 2014:
>
>> Le 2014-09-09 03:32, Hannes Domani a écrit :
>> > p_sys->psz_header was never freed in the loop, nor at the end.
>>
>> So just add the missing free().
>
> Done.

Applied thanks.

>
> But I still think asprintf() is a bad choice here.

Have you profiled to see what kind of impact it has?

Best,
Tristan



More information about the vlc-devel mailing list