[vlc-devel] [PATCH 3/3] subtitle-demux: fix memory leaks (fixes #11908)

Rémi Denis-Courmont remi at remlab.net
Wed Sep 10 17:52:42 CEST 2014


Le mercredi 10 septembre 2014, 12:11:25 Hannes Domani a écrit :
> Rémi Denis-Courmont <remi at remlab.net> schrieb am 8:56 Mittwoch, 10.September 
2014:
> > Le 2014-09-09 03:32, Hannes Domani a écrit :
> > > p_sys->psz_header was never freed in the loop, nor at the end.
> > 
> > So just add the missing free().
> 
> Done.
> 
> But I still think asprintf() is a bad choice here.

I think the entire file is in very poor taste when it comes to memory 
management.

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list