[vlc-devel] [PATCH 01/14] core: add 3D stereo information to video_format_t

[Felix Abecassis]

2014-09-10 13:50 GMT+02:00 Vittorio Giovara <vittorio.giovara at gmail.com>:
> On Wed, Sep 10, 2014 at 10:46 AM, Felix Abecassis
> <felix.abecassis at gmail.com> wrote:
>> 2014-09-09 20:14 GMT+02:00 Rémi Denis-Courmont <remi at remlab.net>:
>>>
>>> Do we really need to separate flags from mode? How many flags are there ever
>>> going to be?
>>>
>>
>> It's not really needed right now indeed, would you be fine with the
>> following instead?
>> VLC_STEREO3D_SBS_LR,
>> VLC_STEREO3D_SBS_RL, ...
>
> I prefer the single version, VLC_STEREO3D_SBS.
> Adding _LR and _RL makes the code less readable and requires twice as
> much work for any check.
>
> Also *in practice* inverted RL files are almost impossible to find
> (while renderers are not, unfortunately), and the most common software
> to produce 3d samples (x264) does not support setting the relevant
> flag anyway.

I think I will stick with the single version indeed if that's OK. With
this version we can simply consider that SBS left-right and SBS
right-left are equivalent.

-- 
Félix Abecassis
http://felix.abecassis.me