[vlc-devel] [PATCH v2 1/2] core: Move httpcookies.c to core

[Rémi Denis-Courmont]

Le samedi 13 septembre 2014, 14:58:45 Antti Ajanki a écrit :
> ---
>  include/vlc_http.h           |   29 ++++
>  modules/access/Makefile.am   |    2 +-
>  modules/access/http.c        |    1 -
>  modules/access/httpcookies.c |  366
> ------------------------------------------ modules/access/httpcookies.h |  
> 62 -------
>  src/Makefile.am              |    1 +
>  src/libvlccore.sym           |    4 +
>  src/misc/httpcookies.c       |  366
> ++++++++++++++++++++++++++++++++++++++++++ 8 files changed, 401
> insertions(+), 430 deletions(-)
>  delete mode 100644 modules/access/httpcookies.c
>  delete mode 100644 modules/access/httpcookies.h
>  create mode 100644 src/misc/httpcookies.c
> 
> diff --git a/include/vlc_http.h b/include/vlc_http.h
> index ddde13e..490e0a2 100644
> --- a/include/vlc_http.h
> +++ b/include/vlc_http.h
> @@ -33,6 +33,9 @@
>   * HTTP clients.
>   */
> 
> +#include <vlc_url.h>
> +#include <vlc_arrays.h>
> +
>  /* RFC 2617: Basic and Digest Access Authentication */
>  typedef struct http_auth_t
>  {
> @@ -64,4 +67,30 @@ VLC_API char *http_auth_FormatAuthorizationHeader
>                const char *, const char *,
>                const char *, const char * ) VLC_USED;
> 
> +/* RFC 6265: cookies */
> +
> +typedef struct vlc_array_t http_cookie_jar_t;
> +
> +VLC_API http_cookie_jar_t * http_cookies_new( void ) VLC_USED;
> +VLC_API void http_cookies_destroy( http_cookie_jar_t * p_jar );

If those become exported functions, they should be prefixed with vlc_ to avoid 
global symbol name space conflicts.

-- 
Rémi Denis-Courmont
http://www.remlab.net/