[vlc-devel] [PATCH v3 2/2] access/http: Share cookies between all playlist items

Antti Ajanki antti.ajanki at iki.fi
Tue Sep 16 20:22:38 CEST 2014

On 15.09.2014 23:40, Rémi Denis-Courmont wrote:
> So either there is a warranty that when playlist_Destroy() is called, no
> thread can be fetching cookies any longer. In that case, the reference counter
> is pointless. Or there is no such warranty and the code is just wrong.
> Hopefully, the earlier. Then don't bother with the reference count.

It is indeed the case that nobody can be fetching the cookies anymore 
when the cookie jar is destroyed, because the playlist_Deactivate() 
called a few lines before cookie jar destruction in playlist_Destroy() 
will stop and join inputs (so there are no active http accesses that 
could use cookies). I will post a patch without the reference counting.


More information about the vlc-devel mailing list