[vlc-devel] [PATCH 1/1] contrib: add (disabled) rules.mak for daala

[Rafaël Carré]

On 09/21/14 16:26, Tristan Matthews wrote:
> ---
>  contrib/src/daala/rules.mak | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 contrib/src/daala/rules.mak
> 
> diff --git a/contrib/src/daala/rules.mak b/contrib/src/daala/rules.mak
> new file mode 100644
> index 0000000..09f32e6
> --- /dev/null
> +++ b/contrib/src/daala/rules.mak
> @@ -0,0 +1,33 @@
> +DAALA_VERSION := git
> +DAALA_HASH := HEAD
> +DAALA_GITURL := http://git.xiph.org/?p=daala.git;a=snapshot;h=$(DAALA_HASH);sf=tgz
> +
> +# Default disabled for now
> +# PKGS += daala
> +ifeq ($(call need_pkg,"daala"),)
> +PKGS_FOUND += daala
> +endif
> +
> +$(TARBALLS)/daala-git.tar.gz:
> +	$(call download,$(DAALA_GITURL))
> +
> +.sum-daala: daala-$(DAALA_VERSION).tar.gz
> +	$(warning $@ not implemented)
> +	touch $@
> +
> +daala: daala-$(DAALA_VERSION).tar.gz .sum-daala
> +	rm -Rf $@-git $@
> +	mkdir -p $@-git
> +	$(ZCAT) "$<" | (cd $@-git && tar xv --strip-components=1)
> +	$(MOVE)
> +
> +DAALACONF := $(HOSTCONF) \
> +	--disable-player --disable-tools
> +
> +DEPS_daala = ogg $(DEPS_ogg)
> +
> +.daala: daala
> +	mkdir -p $</m4 && $(RECONF)

Could be moved to daala: target instead

> +	cd $< && $(HOSTVARS) ./configure $(HOSTCONF) $(DAALACONF)

HOSTCONF is duplicated here

> +	cd $< && $(MAKE) install
> +	touch $@
> 

Else lgtm