[vlc-devel] [vlc-commits] demux: mp4: flag incomplete boxes

Rémi Denis-Courmont remi at remlab.net
Thu Sep 25 18:14:25 CEST 2014


Le mercredi 24 septembre 2014, 22:35:15 Francois Cartegnie a écrit :
> @@ -3914,12 +3915,14 @@ static void MP4_BoxDumpStructure_Internal( stream_t
> *s, }
>          if( MP4_BOX_TYPE_ASCII() )
>              snprintf( &str[i_level * 4], sizeof(str) - 4*i_level,
> -                      "+ %4.4s size %"PRIu64" offset %ld",
> -                        (char*)&p_box->i_type, p_box->i_size, p_box->i_pos
> ); +                      "+ %4.4s size %"PRIu64" offset %ld%s",
> +                        (char*)&p_box->i_type, p_box->i_size, p_box->i_pos,
> +                    p_box->e_flags & BOX_FLAG_INCOMPLETE ? " (????)" : ""

I think we don't allow trigraphs in the VLC code base, and the compiler should 
have warned about that...

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list