[vlc-devel] [PATCH] mp4: fix typos in sizeof guards

Jean-Baptiste Kempf jb at videolan.org
Sun Sep 28 16:53:51 CEST 2014


Applied. Thanks

On 21 Sep, Boris Egorov wrote :
> Detected by CppCheck
> 
> Signed-off-by: Boris Egorov <egorov at linux.com>
> ---
>  modules/mux/mp4.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/modules/mux/mp4.c b/modules/mux/mp4.c
> index 31624ec..bec3435 100644
> --- a/modules/mux/mp4.c
> +++ b/modules/mux/mp4.c
> @@ -2646,9 +2646,9 @@ static bo_t *GetMfraBox(sout_mux_t *p_mux)
>                  const mp4_fragindex_t *p_indexentry = &p_stream->p_indexentries[i_index];
>                  bo_add_32be(tfra, p_indexentry->i_time);
>                  bo_add_32be(tfra, p_indexentry->i_moofoffset);
> -                assert(sizeof(p_indexentry->i_traf==1)); /* guard against sys changes */
> -                assert(sizeof(p_indexentry->i_trun==1));
> -                assert(sizeof(p_indexentry->i_sample==4));
> +                assert(sizeof(p_indexentry->i_traf)==1); /* guard against sys changes */
> +                assert(sizeof(p_indexentry->i_trun)==1);
> +                assert(sizeof(p_indexentry->i_sample)==4);
>                  bo_add_8(tfra, p_indexentry->i_traf);
>                  bo_add_8(tfra, p_indexentry->i_trun);
>                  bo_add_32be(tfra, p_indexentry->i_sample);
> -- 
> 2.1.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list