[vlc-devel] [vlc-commits] en50221: avoid one memory copy (refs #12307)

Rémi Denis-Courmont remi at remlab.net
Mon Sep 29 21:06:41 CEST 2014


Le lundi 29 septembre 2014, 21:01:06 Rémi Denis-Courmont a écrit :
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Sep 29
> 21:59:47 2014 +0300| [34c1ae55153af567ee6d51f53046bbbc3ef39c0c] |
> committer: Rémi Denis-Courmont
> 
> en50221: avoid one memory copy (refs #12307)

I suspect MAX_TPDU_DATA value may be too high. The code seems to try to not 
send more than 4096 bytes at a time. In that, if I understood correctly, 
MAX_TPDU_SIZE should be 4089 rather than 4092.

#define MAX_TPDU_SIZE  4096
#define MAX_TPDU_DATA  (MAX_TPDU_SIZE - 4)

I am not at all familiar with the underlying standard though, so I am not 
going to change that. (This commit should not make any difference.)

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list