[vlc-devel] [vlc-commits] twolame: add error checking

Tristan Matthews le.businessman at gmail.com
Tue Sep 30 13:45:30 CEST 2014


On Tue, Sep 30, 2014 at 2:34 AM, Rémi Denis-Courmont <remi at remlab.net>
wrote:

> Le 2014-09-30 04:07, git at videolan.org a écrit :
>
>>          p_sys->i_nb_samples = 0;
>>          p_block = block_Alloc( i_used );
>> +        if( !p_block )
>> +        {
>> +            if( p_chain )
>> +                block_Release( p_chain );
>>
>
> Isn't that effectively leaking the (rest of the) chain?
>

Yes that should have been block_ChainRelease, thanks for the catch.

Best,
Tristan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140930/5b63178c/attachment.html>


More information about the vlc-devel mailing list