[vlc-devel] [vlc-commits] udp: don't realloc in receiving, just set i_buffer
Rémi Denis-Courmont
remi at remlab.net
Tue Sep 30 21:07:21 CEST 2014
Le mardi 30 septembre 2014, 20:40:44 Ilkka Ollakka a écrit :
> vlc | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Sun Sep 28
> 10:54:23 2014 +0300| [7fff679f1494dbc7475a6010d45bd335f959c912] |
> committer: Ilkka Ollakka
>
> udp: don't realloc in receiving, just set i_buffer
>
> Similar than rtp input does, doing realloc from 64k->1.5k would
> usually mean extra malloc+memcpy per packet.
>
> Also don't pass buffer onward if we don't receive any useful stuff (-1)
Hmm? I think the 'continue' statement was already taking care of that.
Otherwise we would have had a use-after-free. Now the 'continue' is redundant.
--
Rémi Denis-Courmont
http://www.remlab.net/
More information about the vlc-devel
mailing list