[vlc-devel] [PATCH] mediacodec/omxil: blacklist samsung VP8 decoder

Thomas Guillem thomas at gllm.fr
Fri Apr 3 10:58:10 CEST 2015


Fixes #14227
---
 modules/codec/omxil/android_mediacodec.c | 2 ++
 modules/codec/omxil/omxil.c              | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/modules/codec/omxil/android_mediacodec.c b/modules/codec/omxil/android_mediacodec.c
index cacfe1e..aa90cc4 100644
--- a/modules/codec/omxil/android_mediacodec.c
+++ b/modules/codec/omxil/android_mediacodec.c
@@ -397,6 +397,8 @@ static bool codec_is_blacklisted( const char *p_name, unsigned int i_name_len )
         "OMX.google.",
         /* crashes mediaserver */
         "OMX.MTK.VIDEO.DECODER.MPEG4",
+        /* Not working or crashing (Samsung) */
+        "OMX.SEC.vp8.dec",
         NULL,
      };
 
diff --git a/modules/codec/omxil/omxil.c b/modules/codec/omxil/omxil.c
index 9211f76..16eb50e 100644
--- a/modules/codec/omxil/omxil.c
+++ b/modules/codec/omxil/omxil.c
@@ -1141,6 +1141,9 @@ static int OpenGeneric( vlc_object_t *p_this, bool b_encode )
          * it until we can make it work properly. */
         if (!strcmp(p_sys->ppsz_components[i], "OMX.Nvidia.vc1.decode"))
             continue;
+        /* This codec doesn't work or crashes */
+        if (!strcmp(p_sys->ppsz_components[i], "OMX.SEC.vp8.dec"))
+            continue;
 #endif
         omx_error = InitialiseComponent(p_dec, p_sys->ppsz_components[i],
                                         &p_sys->omx_handle);
-- 
2.1.3




More information about the vlc-devel mailing list