[vlc-devel] [PATCH] avcodec: only disable frame threading if DXVA2 is likely to be used

[Steve Lhomme]

On Wed, Apr 1, 2015 at 1:27 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le 2015-03-31 13:16, Steve Lhomme a écrit :
>>
>> Fixes #14054
>
>
> This will leave threading enabled if the video track starts with an
> hardware-unsupported profile, then downgrades to a hardware-supported
> profile (e.g. due to new H.264 SPS). If DxVA2 is compatible with threading,
> then you should remove the whole ifdef. If DxVA2 is not compatible with
> threading, then the patch is wrong.

If the profile changes in the middle of the stream, is the codec
renegotiated ? And if so, at what level ? Because if we close the
previous codec instance and create a new one, it should work. If not,
the other option is to always set thread_safe_callbacks to false for
windows. It will always work. I think the performance impact won't be
very big.