[vlc-devel] [PATCH] DXVA2: relying on a D3D9 DLL might not work in Windows 10

Steve Lhomme robUx4 at videolabs.io
Tue Apr 7 10:28:46 CEST 2015


+ unused variable cleaning
---
 modules/codec/avcodec/dxva2.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/modules/codec/avcodec/dxva2.c b/modules/codec/avcodec/dxva2.c
index 1126d25..1d68216 100644
--- a/modules/codec/avcodec/dxva2.c
+++ b/modules/codec/avcodec/dxva2.c
@@ -486,7 +486,7 @@ static int Extract(vlc_va_t *va, picture_t *picture, void *opaque,
 
     /* */
     IDirect3DSurface9_UnlockRect(d3d);
-    (void) opaque;
+    VLC_UNUSED(opaque);
     return VLC_SUCCESS;
 }
 
@@ -543,7 +543,7 @@ static void Release(void *opaque, uint8_t *data)
         vlc_mutex_lock( surface->p_lock );
 
     surface->refcount--;
-    (void) data;
+    VLC_UNUSED(data);
 
     if ( surface->p_lock )
         vlc_mutex_unlock( surface->p_lock );
@@ -587,6 +587,7 @@ static int Open(vlc_va_t *va, AVCodecContext *ctx, const es_format_t *fmt)
         vlc_mutex_init( &sys->surface_lock );
 
     /* Load dll*/
+    /* FIXME might not work in Win10 */
     sys->hd3d9_dll = LoadLibrary(TEXT("D3D9.DLL"));
     if (!sys->hd3d9_dll) {
         msg_Warn(va, "cannot load d3d9.dll");
-- 
2.3.2




More information about the vlc-devel mailing list