[vlc-devel] [PATCH] DXVA: put the VLC_UNUSED at the beginning or the function

Steve Lhomme robux4 at videolabs.io
Wed Apr 8 07:43:20 CEST 2015


On Tue, Apr 7, 2015 at 5:27 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Why? Leaving aside the matter of taste of the VLC-specific VLC_UNUSED vs the
> standard void cast, what is the point in moving this to the beginning of the
> function?

Because it's more visible when you read the function signature. You
can see quickly which parameters are (ir)relevant.

> Le 2015-04-07 17:31, Steve Lhomme a écrit :
>>
>> ---
>>  modules/codec/avcodec/dxva2.c | 11 ++++++++---
>>  1 file changed, 8 insertions(+), 3 deletions(-)
>
>
> --
> Rémi Denis-Courmont
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list