[vlc-devel] [PATCH] avcodec VA: use the proper type for the pixel format

[Rémi Denis-Courmont]

Le 2015-04-07 11:04, Steve Lhomme a écrit :
> makes debugging nicer

Can't you read the VLC logs?

> and errors less likely

How so?

> ---
>  modules/codec/avcodec/va.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/codec/avcodec/va.h b/modules/codec/avcodec/va.h
> index 64dca01..b7e4e35 100644
> --- a/modules/codec/avcodec/va.h
> +++ b/modules/codec/avcodec/va.h
> @@ -35,7 +35,7 @@ struct vlc_va_t {
>      vlc_va_sys_t *sys;
>      module_t *module;
>      const char *description;
> -    int pix_fmt;
> +    enum PixelFormat pix_fmt;

This makes the VLC plugin ABI dependent on the libavutil version, 
AFAICT. No, thanks.

>
>      int  (*setup)(vlc_va_t *, AVCodecContext *, vlc_fourcc_t 
> *output);
>      int  (*get)(vlc_va_t *, void **opaque, uint8_t **data);

-- 
Rémi Denis-Courmont