[vlc-devel] [PATCH 1/2] audio_filter: SOFAlizer new module

[David Fuhrmann]

Hi,

> +vlc_module_begin ()
> +    set_description( N_("SOFAlizer") )
> +    set_shortname( N_("SOFAlizer") )
> +    set_capability( "audio filter", 0)
> +    set_help( HELP_TEXT )
> +    add_loadfile( "sofalizer-filename1", "", FILE1_NAME_TEXT, FILE_NAME_LONGTEXT, false)
> +    add_loadfile( "sofalizer-filename2", "", FILE2_NAME_TEXT, FILE_NAME_LONGTEXT, false)
> +    add_loadfile( "sofalizer-filename3", "", FILE3_NAME_TEXT, FILE_NAME_LONGTEXT, false)

I do not really like such kind of stuff. Why three file names? If you want to switch to a fourth file, you are screwed. And with this its really hard to integrate it in any UI (for providing on-the-fly change of the file).

Did you tried one variable, and on-the-fly reconfiguration in a variable callback? I think this would be better, and thats what variable callbacks are for.

Best regards,
David