[vlc-devel] (no subject)

[Ricardo Ribalda Delgado]

Return-Path: <ricardo.ribalda at gmail.com>
Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18])
        by mx.google.com with ESMTPSA id 4sm979925lal.36.2015.04.15.07.31.15
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Wed, 15 Apr 2015 07:31:15 -0700 (PDT)
From: Ricardo Ribalda Delgado <ricardo.ribalda at gmail.com>
To: vlc-devel at videolan.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda at gmail.com>
Subject: [PATCH] v4l2: Fix SetupFormat for CONTINUOUS framesize
Date: Wed, 15 Apr 2015 16:31:12 +0200
Message-Id: <1429108272-12250-1-git-send-email-ricardo.ribalda at gmail.com>
X-Mailer: git-send-email 2.1.4

One of the bounds of the loop were wrong, ending up in testing
formats that were not supported by the hardware.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda at gmail.com>
---

Stupid Related question. Why vlc prefers fast frames in favour of
big frames?

I have a camera that supports framesizes from 4x1 to 1024x1024, and 
the tiny useless frames are autoselected :S.

Would a patch to invert this preference be accepted?

Thanks!

 modules/access/v4l2/video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/access/v4l2/video.c b/modules/access/v4l2/video.c
index fe5d1c9..b8544ea 100644
--- a/modules/access/v4l2/video.c
+++ b/modules/access/v4l2/video.c
@@ -508,7 +508,7 @@ int SetupFormat (vlc_object_t *obj, int fd, uint32_t fourcc,
                           width <= fse.stepwise.max_width;
                           width += fse.stepwise.step_width)
                 for (uint32_t height =  fse.stepwise.min_height;
-                              height <= fse.stepwise.max_width;
+                              height <= fse.stepwise.max_height;
                               height += fse.stepwise.step_height)
                 {
                     struct v4l2_fract cur_it;
-- 
2.1.4